Bump to ginkgo/v2 && lager/v3 #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsabeti
reviewed
Apr 6, 2023
evacuation/cleanup_test.go
Outdated
| fakeClock.Increment(time.Second * 1) | ||
| nil, | ||
| ) | ||
| fakeExecutorClient.ListContainersReturnsOnCall(3, []executor.Container{}, nil) |
There was a problem hiding this comment.
Any reason you changed the call count from 2 to 3?
I actually ran this test locally, once with the value set to 3, again with the value set to 2, and again with the line removed entirely, and all three runs passed 🤔
Might be best to just delete this line? I suspect counterfeiter returns empty values for calls with indexes that weren't specified ahead of time in stubs.
dsabeti
approved these changes
Apr 6, 2023
Context: #39 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.